AlmightyHak/extensions-source
2
0
Fork 1
Code Issues 296 Pull requests 6 Projects Releases Packages Wiki Activity Actions 1

FRAnime: JSON title is missing fix #87

Merged
JosefFStraka merged 2 commits from franime-fix into main 2024-07-29 20:21:50 -05:00
Conversation 0 Commits 2 Files changed 2 +2 -2
JosefFStraka commented 2024-07-29 15:30:48 -05:00 (Migrated from github.com)
Copy link

Not the best fix but it counts

Closes #74

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
Not the best fix but it counts Closes #74 - [x] Updated `extVersionCode` value in `build.gradle` for individual extensions - [ ] ~~Updated `overrideVersionCode` or `baseVersionCode` as needed for all multisrc extensions~~ - [x] Referenced all related issues in the PR body (e.g. "Closes #xyz") - [x] `isNsfw = true` flag in `build.gradle` when appropriate - [x] Have not changed source names - [x] Have explicitly kept the `id` if a source's name or language were changed - [x] Have tested the modifications by compiling and running the extension through Android Studio - [ ] ~~Have removed `web_hi_res_512.png` when adding a new extension~~
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something isn't working

  
Domain change

Domain changed

  
Duplicate

This issue or pull request already exists

  
Features request

New features requests for existing sources

  
Remove request

Scanlators can request their site to be removed

  
Source is down

the source got taken down/removed

  
Source request

requesting a new source

  
Wont fix

This will not be worked on

No labels
Bug
Domain change
Duplicate
Features request
Remove request
Source is down
Source request
Wont fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AlmightyHak/extensions-source#87
No description provided.
Delete branch "franime-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?