Kohi-den/extensions-source
2
0
Fork 0
Code Issues 297 Pull requests 5 Projects Releases Packages Wiki Activity Actions

Add Subsplease #120

Merged
vvirtues merged 5 commits from subsplease into main 2024-08-10 00:32:04 -05:00
Conversation 7 Commits 5 Files changed 8 +238
vvirtues commented 2024-08-07 16:46:29 -05:00 (Migrated from github.com)
Copy link

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • Have made sure all the icons are in png format
Checklist: - [x] Updated `extVersionCode` value in `build.gradle` for individual extensions - [x] Updated `overrideVersionCode` or `baseVersionCode` as needed for all multisrc extensions - [x] Referenced all related issues in the PR body (e.g. "Closes #xyz") - [x] Added the `isNsfw = true` flag in `build.gradle` when appropriate - [x] Have not changed source names - [x] Have explicitly kept the `id` if a source's name or language were changed - [x] Have tested the modifications by compiling and running the extension through Android Studio - [x] Have removed `web_hi_res_512.png` when adding a new extension - [x] Have made sure all the icons are in png format
vvirtues commented 2024-08-07 17:21:02 -05:00 (Migrated from github.com)
Copy link

how do i test it
i opened in android studio what now

how do i test it i opened in android studio what now
vvirtues commented 2024-08-07 17:55:58 -05:00 (Migrated from github.com)
Copy link

image
guess it works

![image](https://github.com/user-attachments/assets/88c24df8-1a70-4ee4-918c-ede67da8643a) guess it works
vvirtues commented 2024-08-07 17:56:03 -05:00 (Migrated from github.com)
Copy link

image
guess it works

![image](https://github.com/user-attachments/assets/88c24df8-1a70-4ee4-918c-ede67da8643a) guess it works
mobby45 commented 2024-08-09 09:01:54 -05:00 (Migrated from github.com)
Copy link

to test it, install aniyomi on and launch it

to test it, install aniyomi on and launch it
vvirtues commented 2024-08-09 09:54:27 -05:00 (Migrated from github.com)
Copy link

Yes it works with aniyomi

On August 9, 2024 10:02:15 a.m. EDT, mobby45 @.***> wrote:

to test it, install aniyomi on and launch it

--
Reply to this email directly or view it on GitHub:
https://github.com/almightyhak/aniyomi-extensions/pull/120#issuecomment-2278018751
You are receiving this because you authored the thread.

Message ID: @.***>

Yes it works with aniyomi On August 9, 2024 10:02:15 a.m. EDT, mobby45 ***@***.***> wrote: >to test it, install aniyomi on and launch it > >-- >Reply to this email directly or view it on GitHub: >https://github.com/almightyhak/aniyomi-extensions/pull/120#issuecomment-2278018751 >You are receiving this because you authored the thread. > >Message ID: ***@***.***>
mrtear commented 2024-08-14 16:28:52 -05:00 (Migrated from github.com)
Copy link

Yes it works with aniyomi

@vvirtues (sry for the @)
I know it’s weird to receive a reply to a closed issue, but…

I noticed that the SubsPlease extension isn’t working on the official Aniyomi app, but it works on forks of Aniyomi that support torrents. Have you tested it with Aniyomi forks or the official app? Should I open an issue on github?
error

> Yes it works with aniyomi @vvirtues (sry for the @) I know it’s weird to receive a reply to a closed issue, but… I noticed that the SubsPlease extension isn’t working on the official Aniyomi app, but it works on forks of Aniyomi that support torrents. Have you tested it with Aniyomi forks or the official app? Should I open an issue on github? ![error](https://github.com/user-attachments/assets/7c265817-e526-4d43-ac47-78f794d6819b)
vvirtues commented 2024-08-14 16:56:06 -05:00 (Migrated from github.com)
Copy link

no its meant for torrents. also weird that i never got notified of this

Yes it works with aniyomi

@vvirtues (sry for the @) I know it’s weird to receive a reply to a closed issue, but…

I noticed that the SubsPlease extension isn’t working on the official Aniyomi app, but it works on forks of Aniyomi that support torrents. Have you tested it with Aniyomi forks or the official app? Should I open an issue on github? error

no its meant for torrents. also weird that i never got notified of this > > Yes it works with aniyomi > > @vvirtues (sry for the @) I know it’s weird to receive a reply to a closed issue, but… > > I noticed that the SubsPlease extension isn’t working on the official Aniyomi app, but it works on forks of Aniyomi that support torrents. Have you tested it with Aniyomi forks or the official app? Should I open an issue on github? ![error](https://private-user-images.githubusercontent.com/91820779/358014479-7c265817-e526-4d43-ac47-78f794d6819b.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2NzI4MzMsIm5iZiI6MTcyMzY3MjUzMywicGF0aCI6Ii85MTgyMDc3OS8zNTgwMTQ0NzktN2MyNjU4MTctZTUyNi00ZDQzLWFjNDctNzhmNzk0ZDY4MTliLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE0VDIxNTUzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlkMDk1ZmJhMGEzOGFmMjM1MzExMmU1ZDlmZjRhZjBhOTU0ODBmNzY4MzBlYjE3NGIyM2Y4YjE5ZWU2Zjg4ODgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.gjjxXL5raLwjjnaTBa4FOIgwpxpE76BIOucUSNynPV8)
👀 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something isn't working

  
Domain change

Domain changed

  
Duplicate

This issue or pull request already exists

  
Features request

New features requests for existing sources

  
Remove request

Scanlators can request their site to be removed

  
Source is down

the source got taken down/removed

  
Source request

requesting a new source

  
Wont fix

This will not be worked on

No labels
Bug
Domain change
Duplicate
Features request
Remove request
Source is down
Source request
Wont fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Kohi-den/extensions-source#120
No description provided.
Delete branch "subsplease"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?