Kohi-den/extensions-source
2
0
Fork 0
Code Issues 297 Pull requests 5 Projects Releases Packages Wiki Activity Actions

fix(all/torrentioanime): Fix fetching episode list #192

Merged
Grafcube merged 1 commit from fix-torrentio-anime into main 2024-09-01 17:51:00 -05:00
Conversation 0 Commits 1 Files changed 2 +6 -2
Grafcube commented 2024-08-31 11:11:09 -05:00 (Migrated from github.com)
Copy link

The episode list for the wrong anime was returned by the old url. This patch fixes that by specifically using the kitsu id instead.

Demo (at the time of this PR):

Actual Anilist ID: 166531
Corresponding Kitsu ID: 47659

Wrong metadata: https://anime-kitsu.strem.fun/meta/series/anilist%3A166531.json
Correct metadata: https://anime-kitsu.strem.fun/meta/series/kitsu%3A47659.json

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • Have made sure all the icons are in png format
The episode list for the wrong anime was returned by the old url. This patch fixes that by specifically using the kitsu id instead. Demo (at the time of this PR): Actual Anilist ID: 166531 Corresponding Kitsu ID: 47659 Wrong metadata: <https://anime-kitsu.strem.fun/meta/series/anilist%3A166531.json> Correct metadata: <https://anime-kitsu.strem.fun/meta/series/kitsu%3A47659.json> Checklist: - [x] Updated `extVersionCode` value in `build.gradle` for individual extensions - [ ] Updated `overrideVersionCode` or `baseVersionCode` as needed for all multisrc extensions - [ ] Referenced all related issues in the PR body (e.g. "Closes #xyz") - [ ] Added the `isNsfw = true` flag in `build.gradle` when appropriate - [x] Have not changed source names - [ ] Have explicitly kept the `id` if a source's name or language were changed - [x] Have tested the modifications by compiling and running the extension through Android Studio - [ ] Have removed `web_hi_res_512.png` when adding a new extension - [ ] Have made sure all the icons are in png format
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something isn't working

  
Domain change

Domain changed

  
Duplicate

This issue or pull request already exists

  
Features request

New features requests for existing sources

  
Remove request

Scanlators can request their site to be removed

  
Source is down

the source got taken down/removed

  
Source request

requesting a new source

  
Wont fix

This will not be worked on

No labels
Bug
Domain change
Duplicate
Features request
Remove request
Source is down
Source request
Wont fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Kohi-den/extensions-source#192
No description provided.
Delete branch "fix-torrentio-anime"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?