AlmightyHak/extensions-source
2
0
Fork 1
Code Issues 296 Pull requests 6 Projects Releases Packages Wiki Activity Actions

[animeowl] fix: Quality preference match #880

Open
khaled-0 wants to merge 2 commits from khaled-0/patch-1 into main
pull from: khaled-0/patch-1
merge into: AlmightyHak:main
Conversation 7 Commits 2 Files changed 3 +14 -6
khaled-0 commented 2025-04-05 11:57:17 -05:00 (Migrated from github.com)
Copy link

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • Have made sure all the icons are in png format
Checklist: - [x] Updated `extVersionCode` value in `build.gradle` for individual extensions - [ ] Updated `overrideVersionCode` or `baseVersionCode` as needed for all multisrc extensions - [ ] Referenced all related issues in the PR body (e.g. "Closes #xyz") - [ ] Added the `isNsfw = true` flag in `build.gradle` when appropriate - [x] Have not changed source names - [ ] Have explicitly kept the `id` if a source's name or language were changed - [x] Have tested the modifications by compiling and running the extension through Android Studio - [ ] Have removed `web_hi_res_512.png` when adding a new extension - [ ] Have made sure all the icons are in png format
cuong-tran (Migrated from github.com) reviewed 2025-04-05 11:57:17 -05:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-04-06 13:43:51 -05:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy link

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Dark25 commented 2025-04-06 13:45:18 -05:00 (Migrated from github.com)
Copy link

@khaled-0 Update version, Have you tested that everything works fine in Android Studio?

@khaled-0 Update version, Have you tested that everything works fine in Android Studio?
khaled-0 commented 2025-04-06 23:53:57 -05:00 (Migrated from github.com)
Copy link

It was meant to be still a draft. I'm looking at more issues. Updated to draft

It was meant to be still a draft. I'm looking at more issues. Updated to draft
cuong-tran (Migrated from github.com) reviewed 2025-04-11 10:21:39 -05:00
src/en/animeowl/src/eu/kanade/tachiyomi/animeextension/en/animeowl/extractors/OwlExtractor.kt
@ -48,8 +48,13 @@ class OwlExtractor(private val client: OkHttpClient, private val baseUrl: String
luffy.forEach { stream ->
cuong-tran (Migrated from github.com) commented 2025-04-11 10:21:39 -05:00
Copy link

wouldn't this only add an extra "p" to the video's title? What does it fix? What was the issue?

wouldn't this only add an extra "p" to the video's title? What does it fix? What was the issue?
khaled-0 (Migrated from github.com) reviewed 2025-04-11 10:39:46 -05:00
src/en/animeowl/src/eu/kanade/tachiyomi/animeextension/en/animeowl/extractors/OwlExtractor.kt
@ -48,8 +48,13 @@ class OwlExtractor(private val client: OkHttpClient, private val baseUrl: String
luffy.forEach { stream ->
khaled-0 (Migrated from github.com) commented 2025-04-11 10:39:46 -05:00
Copy link

No this is the 480p 1080p quality. The download isn't picking 1080p as the prefered quality. that's the issue

however there's a new 2K option which should also be added and accounted for.
This commit would fix the prefered quality issue as I've tested. however there's another bug that the page 2 of the extension doesn't load.

No this is the 480p 1080p quality. The download isn't picking 1080p as the prefered quality. that's the issue however there's a new 2K option which should also be added and accounted for. This commit would fix the prefered quality issue as I've tested. however there's another bug that the page 2 of the extension doesn't load.
khaled-0 commented 2025-04-21 00:15:17 -05:00 (Migrated from github.com)
Copy link

Okay, so the page 2 json bug seem to have vanished. I've added the 2K quality in the meantime. good to go

Okay, so the page 2 json bug seem to have vanished. I've added the 2K quality in the meantime. good to go
🚀 1
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin khaled-0/patch-1:khaled-0/patch-1
git checkout khaled-0/patch-1

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff khaled-0/patch-1
git checkout khaled-0/patch-1
git rebase main
git checkout main
git merge --ff-only khaled-0/patch-1
git checkout khaled-0/patch-1
git rebase main
git checkout main
git merge --no-ff khaled-0/patch-1
git checkout main
git merge --squash khaled-0/patch-1
git checkout main
git merge --ff-only khaled-0/patch-1
git checkout main
git merge khaled-0/patch-1
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
cuong-tran
Labels
Clear labels   
Bug

Something isn't working

  
Domain change

Domain changed

  
Duplicate

This issue or pull request already exists

  
Features request

New features requests for existing sources

  
Remove request

Scanlators can request their site to be removed

  
Source is down

the source got taken down/removed

  
Source request

requesting a new source

  
Wont fix

This will not be worked on

No labels
Bug
Domain change
Duplicate
Features request
Remove request
Source is down
Source request
Wont fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AlmightyHak/extensions-source#880
No description provided.
Delete branch "khaled-0/patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?