AlmightyHak/extensions-source
2
0
Fork 1
Code Issues 296 Pull requests 6 Projects Releases Packages Wiki Activity Actions 1

Kickassanime & Hianime: Fix subtitles #937

Merged
V3u47ZoN merged 13 commits from subs into main 2025-04-24 06:53:04 -05:00
Conversation 16 Commits 13 Files changed 4 +35 -5
V3u47ZoN commented 2025-04-21 11:06:12 -05:00 (Migrated from github.com)
Copy link

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions handled by lib bump
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions handled by lib bump
  • Referenced all related issues in the PR body (e.g. "Closes #xyz") no report on github, only on discord
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • Have made sure all the icons are in png format

If the cue text contained empty lines then subtitles would fail to show up: 1363874613 & 1364456864

Example of broken subtitles:
Kickassanime: death note episode 36
Hianime: witch watch episode 3 @ 17:20

Checklist: - [x] ~~Updated extVersionCode value in build.gradle for individual extensions~~ handled by lib bump - [x] ~~Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions~~ handled by lib bump - [x] ~~Referenced all related issues in the PR body (e.g. "Closes #xyz")~~ no report on github, only on discord - [x] Added the isNsfw = true flag in build.gradle when appropriate - [x] Have not changed source names - [x] Have explicitly kept the id if a source's name or language were changed - [x] Have tested the modifications by compiling and running the extension through Android Studio - [x] Have removed web_hi_res_512.png when adding a new extension - [x] Have made sure all the icons are in png format If the cue text contained empty lines then subtitles would fail to show up: https://discord.com/channels/1253381712306634904/1253387549246754937/1363874613611855962 & https://discord.com/channels/1253381712306634904/1253387549246754937/1364456864011784203 Example of broken subtitles: Kickassanime: death note episode 36 Hianime: witch watch episode 3 @ 17:20
Arkai1 (Migrated from github.com) reviewed 2025-04-21 21:05:29 -05:00
Arkai1 (Migrated from github.com) left a comment
Copy link

If you have made changes in Aniplay.kt, have you updated the version code in build.gradle. Update version code in build.gradle so it will not conflict with current build

If you have made changes in Aniplay.kt, have you updated the version code in build.gradle. Update version code in build.gradle so it will not conflict with current build
V3u47ZoN commented 2025-04-22 00:51:02 -05:00 (Migrated from github.com)
Copy link

If you have made changes in Aniplay.kt, have you updated the version code in build.gradle. Update version code in build.gradle so it will not conflict with current build

back before dmca updating a lib would automatically bump all extensions using it is that not the case anymore ?

> If you have made changes in Aniplay.kt, have you updated the version code in build.gradle. Update version code in build.gradle so it will not conflict with current build back before dmca updating a lib would automatically bump all extensions using it is that not the case anymore ?
Arkai1 commented 2025-04-22 00:56:45 -05:00 (Migrated from github.com)
Copy link

If you have made changes in Aniplay.kt, have you updated the version code in build.gradle. Update version code in build.gradle so it will not conflict with current build

back before dmca updating a lib would automatically bump all extensions using it is that not the case anymore ?

👍 Then no issue (I forgot about this), But updating the build.gradle would be safe if you have made changes in specific Extension.kt still updating library bump all extensions using it.

> > If you have made changes in Aniplay.kt, have you updated the version code in build.gradle. Update version code in build.gradle so it will not conflict with current build > > back before dmca updating a lib would automatically bump all extensions using it is that not the case anymore ? 👍 Then no issue (I forgot about this), But updating the build.gradle would be safe if you have made changes in specific Extension.kt still updating library bump all extensions using it.
V3u47ZoN commented 2025-04-22 01:34:03 -05:00 (Migrated from github.com)
Copy link

If you have made changes in Aniplay.kt, have you updated the version code in build.gradle. Update version code in build.gradle so it will not conflict with current build

back before dmca updating a lib would automatically bump all extensions using it is that not the case anymore ?

👍 Then no issue (I forgot about this), But updating the build.gradle would be safe if you have made changes in specific Extension.kt still updating library bump all extensions using it.

Ok i update

> > > If you have made changes in Aniplay.kt, have you updated the version code in build.gradle. Update version code in build.gradle so it will not conflict with current build > > > > > > back before dmca updating a lib would automatically bump all extensions using it is that not the case anymore ? > > 👍 Then no issue (I forgot about this), But updating the build.gradle would be safe if you have made changes in specific Extension.kt still updating library bump all extensions using it. Ok i update
Arkai1 (Migrated from github.com) approved these changes 2025-04-22 06:08:41 -05:00
Arkai1 (Migrated from github.com) reviewed 2025-04-22 06:10:18 -05:00
Arkai1 (Migrated from github.com) left a comment
Copy link

Leave the version code to 5 for zoro theme as there is no need for updating its base version code

Leave the version code to 5 for zoro theme as there is no need for updating its base version code
V3u47ZoN (Migrated from github.com) reviewed 2025-04-22 12:21:52 -05:00
V3u47ZoN commented 2025-04-23 00:07:17 -05:00 (Migrated from github.com)
Copy link

Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you.

Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you.
Arkai1 (Migrated from github.com) approved these changes 2025-04-23 00:19:54 -05:00
lib-multisrc/zorotheme/build.gradle.kts
Arkai1 (Migrated from github.com) commented 2025-04-22 06:11:38 -05:00
Copy link

baseVersioncode = 5

baseVersioncode = 5
Arkai1 commented 2025-04-23 00:21:08 -05:00 (Migrated from github.com)
Copy link

Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you.

Ask GregiPlays or hak in the dev chat of discord and complete the checks

> Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you. Ask GregiPlays or hak in the dev chat of discord and complete the checks
V3u47ZoN commented 2025-04-23 04:20:26 -05:00 (Migrated from github.com)
Copy link

Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you.

Ask GregiPlays or hak in the dev chat of discord and complete the checks

I have done all the checks, i just removed the ones that arent relevant here, i can add them back if you like. Also, the discord server requires a verified phone number to speak so i cannot talk there.

> > Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you. > > Ask GregiPlays or hak in the dev chat of discord and complete the checks I have done all the checks, i just removed the ones that arent relevant here, i can add them back if you like. Also, the discord server requires a verified phone number to speak so i cannot talk there.
Arkai1 commented 2025-04-23 04:23:47 -05:00 (Migrated from github.com)
Copy link

Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you.

Ask GregiPlays or hak in the dev chat of discord and complete the checks

I have done all the checks, i just removed the ones that arent relevant here, i can add them back if you like. Also, the discord server requires a verified phone number to speak so i cannot talk there.

Have you run the pr checks jobs

> > > Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you. > > > > > > Ask GregiPlays or hak in the dev chat of discord and complete the checks > > I have done all the checks, i just removed the ones that arent relevant here, i can add them back if you like. Also, the discord server requires a verified phone number to speak so i cannot talk there. Have you run the pr checks jobs
V3u47ZoN commented 2025-04-23 04:25:29 -05:00 (Migrated from github.com)
Copy link

Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you.

Ask GregiPlays or hak in the dev chat of discord and complete the checks

I have done all the checks, i just removed the ones that arent relevant here, i can add them back if you like. Also, the discord server requires a verified phone number to speak so i cannot talk there.

Have you run the pr checks jobs

A maintainer needs to approve it, theres nothing i can do except wait for someone to approve

> > > > Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you. > > > > > > > > > Ask GregiPlays or hak in the dev chat of discord and complete the checks > > > > > > I have done all the checks, i just removed the ones that arent relevant here, i can add them back if you like. Also, the discord server requires a verified phone number to speak so i cannot talk there. > > Have you run the pr checks jobs A maintainer needs to approve it, theres nothing i can do except wait for someone to approve
Arkai1 commented 2025-04-23 04:27:39 -05:00 (Migrated from github.com)
Copy link

Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you.

Ask GregiPlays or hak in the dev chat of discord and complete the checks

I have done all the checks, i just removed the ones that arent relevant here, i can add them back if you like. Also, the discord server requires a verified phone number to speak so i cannot talk there.

Have you run the pr checks jobs

A maintainer needs to approve it, theres nothing i can do except wait for someone to approve

Will ask GregiPlays to check it

> > > > > Ok i fixed the codes now, since aniplay and kickassanime relies on playlist-utils, which was changed, theres no need to manually bump the version just like with zorotheme. I hope you can merge this as soon as possible, thank you. > > > > > > > > > > > > Ask GregiPlays or hak in the dev chat of discord and complete the checks > > > > > > > > > I have done all the checks, i just removed the ones that arent relevant here, i can add them back if you like. Also, the discord server requires a verified phone number to speak so i cannot talk there. > > > > > > Have you run the pr checks jobs > > A maintainer needs to approve it, theres nothing i can do except wait for someone to approve Will ask GregiPlays to check it
krysanify commented 2025-04-23 20:51:03 -05:00 (Migrated from github.com)
Copy link

since aniplay and kickassanime relies on playlist-utils

there are more than these two that use playlist-utils tho i don't know how many actually extract subtitles. consider testing on those exts as well (assuming that they were working before these changes)

> since aniplay and kickassanime relies on playlist-utils there are more than these two that use playlist-utils tho i don't know how many actually extract subtitles. consider testing on those exts as well (assuming that they were working before these changes)
V3u47ZoN commented 2025-04-24 00:00:59 -05:00 (Migrated from github.com)
Copy link

since aniplay and kickassanime relies on playlist-utils

there are more than these two that use playlist-utils tho i don't know how many actually extract subtitles. consider testing on those exts as well (assuming that they were working before these changes)

Since the function isn't actually used in playlist-utils but rather something that the extensions have to opt-in to use its not going to affect any other extension

> > since aniplay and kickassanime relies on playlist-utils > > there are more than these two that use playlist-utils tho i don't know how many actually extract subtitles. consider testing on those exts as well (assuming that they were working before these changes) Since the function isn't actually used in playlist-utils but rather something that the extensions have to opt-in to use its not going to affect any other extension
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Arkai1
Labels
Clear labels   
Bug

Something isn't working

  
Domain change

Domain changed

  
Duplicate

This issue or pull request already exists

  
Features request

New features requests for existing sources

  
Remove request

Scanlators can request their site to be removed

  
Source is down

the source got taken down/removed

  
Source request

requesting a new source

  
Wont fix

This will not be worked on

No labels
Bug
Domain change
Duplicate
Features request
Remove request
Source is down
Source request
Wont fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AlmightyHak/extensions-source#937
No description provided.
Delete branch "subs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?