Voe: adapt to changes in obfuscation (Kohi-den#959)

Sphereso commented

2025-04-29 08:03:12 -05:00

(Migrated from github.com)

fixes #959

Checklist:

Updated extVersionCode value in build.gradle for individual extensions
Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
Referenced all related issues in the PR body (e.g. "Closes #xyz")
Added the isNsfw = true flag in build.gradle when appropriate
Have not changed source names
Have explicitly kept the id if a source's name or language were changed
Have tested the modifications by compiling and running the extension through Android Studio
Have removed web_hi_res_512.png when adding a new extension
Have made sure all the icons are in png format

fixes #959 Checklist: - [x] Updated `extVersionCode` value in `build.gradle` for individual extensions - [x] Updated `overrideVersionCode` or `baseVersionCode` as needed for all multisrc extensions - [x] Referenced all related issues in the PR body (e.g. "Closes #xyz") - [x] Added the `isNsfw = true` flag in `build.gradle` when appropriate - [x] Have not changed source names - [x] Have explicitly kept the `id` if a source's name or language were changed - [x] Have tested the modifications by compiling and running the extension through Android Studio - [x] Have removed `web_hi_res_512.png` when adding a new extension - [x] Have made sure all the icons are in png format

krysanify commented

2025-04-29 08:35:18 -05:00

(Migrated from github.com)

have you tested to check if this also fix #824? if yes (tested & fixed), please add "Closes #824" as well in PR message.

krysanify commented

2025-04-29 08:46:39 -05:00

(Migrated from github.com)

a quick search shows that this voe extractor is used in many other extensions, please test them all for any regression (assuming they were working before this).

a quick search shows that this voe extractor is used in many other extensions, please test them all for any regression (assuming they were working before this). ![voe usages](https://github.com/user-attachments/assets/832f0dd9-fa46-4b33-9ce8-cfd798574eb8)

Sphereso commented

2025-04-29 17:37:50 -05:00

(Migrated from github.com)

have you tested to check if this also fix #824? if yes (tested & fixed), please add "Closes #824" as well in PR message.

extracting the hls data and streaming the actual video is unrelated

a quick search shows that this voe extractor is used in many other extensions, please test them all for any regression (assuming they were working before this).

voe completely changed how they hide the video link therefor the current version of the voe extractor does not work in any extension

> have you tested to check if this also fix #824? if yes (tested & fixed), please add "Closes #824" as well in PR message. extracting the hls data and streaming the actual video is unrelated > a quick search shows that this voe extractor is used in many other extensions, please test them all for any regression (assuming they were working before this). voe completely changed how they hide the video link therefor the current version of the voe extractor does not work in any extension

krysanify commented

2025-04-30 03:40:10 -05:00

(Migrated from github.com)

extracting the hls data and streaming the actual video is unrelated

sure, I assumed that you fixed it to watch things and so you might as well check if the skipping issue still occurs or not. I guess I assumed wrong then.

voe completely changed how they hide the video link therefor the current version of the voe extractor does not work in any extension

so you're not going to test on those other affected extensions. noted.

> extracting the hls data and streaming the actual video is unrelated sure, I assumed that you fixed it to watch things and so you might as well check if the skipping issue still occurs or not. I guess I assumed wrong then. > voe completely changed how they hide the video link therefor the current version of the voe extractor does not work in any extension so you're not going to test on those other affected extensions. noted.

Sphereso commented

2025-04-30 03:56:50 -05:00

(Migrated from github.com)

sure, I assumed that you fixed it to watch things and so you might as well check if the skipping issue still occurs or not. I guess I assumed wrong then.

i have rarely encountered this issue myself while watching. I am not an expert in the HLS protocol but my assumption is that it is something related to how voe is streaming the video. Therefor this is either an issue on voe side or aniyomis video player itself

so you're not going to test on those other affected extensions. noted.

till now i tested every multilanguage, english and german extension using voe. Voe is broken in every single one of them

> sure, I assumed that you fixed it to watch things and so you might as well check if the skipping issue still occurs or not. I guess I assumed wrong then. i have rarely encountered this issue myself while watching. I am not an expert in the HLS protocol but my assumption is that it is something related to how voe is streaming the video. Therefor this is either an issue on voe side or aniyomis video player itself > so you're not going to test on those other affected extensions. noted. till now i tested every multilanguage, english and german extension using voe. Voe is broken in every single one of them

krysanify commented

2025-04-30 04:10:00 -05:00

(Migrated from github.com)

till now i tested every multilanguage, english and german extension using voe. Voe is broken in every single one of them

ah, I didn't mean to test them without your changes. I meant to test them with your changes. If they're working now with your changes then it's great and we might be able to close other no videos issues on those extensions.

> till now i tested every multilanguage, english and german extension using voe. Voe is broken in every single one of them ah, I didn't mean to test them **without** your changes. I meant to test them **with** your changes. If they're working now with your changes then it's great and we might be able to close other no videos issues on those extensions.

Sphereso commented

2025-04-30 05:25:31 -05:00

(Migrated from github.com)

ah, I didn't mean to test them without your changes. I meant to test them with your changes. If they're working now with your changes then it's great and we might be able to close other no videos issues on those extensions.

works like a charm.
disclaimer: i only tested on english, german and multilang extensions that worked (found shows)

on another thought maybe we could better report what went wrong in the extractors if there is a way to do that.
"Video list is empty" prompts you to think that there is just no video present but in most cases that is not the cause. If we could report to the user that something went wrong in the parsing issues like this one would be way easier to point out.

Voe is not the only extractor that doesn't work at all. I'm looking into the Filemoon extractor right now which is also completely broken

> ah, I didn't mean to test them **without** your changes. I meant to test them **with** your changes. If they're working now with your changes then it's great and we might be able to close other no videos issues on those extensions. works like a charm. disclaimer: i only tested on english, german and multilang extensions that worked (found shows) on another thought maybe we could better report what went wrong in the extractors if there is a way to do that. "Video list is empty" prompts you to think that there is just no video present but in most cases that is not the cause. If we could report to the user that something went wrong in the parsing issues like this one would be way easier to point out. Voe is not the only extractor that doesn't work at all. I'm looking into the Filemoon extractor right now which is also completely broken

krysanify commented

2025-04-30 05:44:33 -05:00

(Migrated from github.com)

i only tested on english, german and multilang extensions that worked (found shows)

understand, good enough for me.

on another thought maybe we could better report what went wrong in the extractors if there is a way to do that. "Video list is empty" prompts you to think that there is just no video present but in most cases that is not the cause. If we could report to the user that something went wrong in the parsing issues like this one would be way easier to point out.

i think that message is from app when the function returns empty list. maybe throw an exception with custom message could work?

Voe is not the only extractor that doesn't work at all. I'm looking into the Filemoon extractor right now which is also completely broken

nice and thanks!

> i only tested on english, german and multilang extensions that worked (found shows) understand, good enough for me. > on another thought maybe we could better report what went wrong in the extractors if there is a way to do that. "Video list is empty" prompts you to think that there is just no video present but in most cases that is not the cause. If we could report to the user that something went wrong in the parsing issues like this one would be way easier to point out. i think that message is from app when the function returns empty list. maybe throw an exception with custom message could work? > Voe is not the only extractor that doesn't work at all. I'm looking into the Filemoon extractor right now which is also completely broken nice and thanks!

Sphereso commented

2025-04-30 06:00:56 -05:00

(Migrated from github.com)

i think that message is from app when the function returns empty list. maybe throw an exception with custom message could work?

i tried it. Throwing an exception displays a message but also stops the entire video parsing which renders the entire extension unusable when a single extractor is not working. So that's not an option
I'll see if i can find a way but other than that this should be solved

> i think that message is from app when the function returns empty list. maybe throw an exception with custom message could work? i tried it. Throwing an exception displays a message but also stops the entire video parsing which renders the entire extension unusable when a single extractor is not working. So that's not an option I'll see if i can find a way but other than that this should be solved

👍 1

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin Sphereso/voe-patch:Sphereso/voe-patch

git checkout Sphereso/voe-patch

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff Sphereso/voe-patch

git checkout Sphereso/voe-patch

git rebase main

git checkout main

git merge --ff-only Sphereso/voe-patch

git checkout Sphereso/voe-patch

git rebase main

git checkout main

git merge --no-ff Sphereso/voe-patch

git checkout main

git merge --squash Sphereso/voe-patch

git checkout main

git merge --ff-only Sphereso/voe-patch

git checkout main

git merge Sphereso/voe-patch

git push origin main

Rows
Columns

Voe: adapt to changes in obfuscation (Kohi-den#959) #960

Checkout

Merge